netdev - Re: [External] : Re: [PATCH net-next] udp_tunnel: Fix typo using netdev_WARN instead of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f45be394-9130-4452-afec-c441f6857708@oracle.com>
Date: Thu, 4 Sep 2025 20:11:36 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, dsahern@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [External] : Re: [PATCH net-next] udp_tunnel: Fix typo using
 netdev_WARN instead of netdev_warn

On 9/4/2025 7:58 PM, Jakub Kicinski wrote:
> On Thu, 4 Sep 2025 19:15:57 +0530 ALOK TIWARI wrote:
>> since WARN() triggers backtrace and dumps the file name
>> it is not require here. The failure in udp_tunnel_nic_register()
>> should just be treated as an expected operation failure, not as a kernel bug
> 
> You keep saying that without really explaining why.
> I can make a guess, but the motivation should really be part of
> the commit msg.

Thanks Jakub.

Thanks for pointing that out.

I was referring to the comment in include/linux/netdevice.h
which notes that netdev_WARN() uses WARN/WARN_ON to print
a backtrace along with file/line information.

In this case, udp_tunnel_nic_register() returning an error is
just a failed operation, not a kernel bug. So a simple warning
message is appropriate, and netdev_warn() should be used
instead of netdev_WARN().
That is my understanding here.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/netdevice.h#n5525

Thanks,
Alok