netdev - Re: [PATCH net-next v5 4/9] vsock/loopback: add netns support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLnFESZSETzh/jMh@devvm11784.nha0.facebook.com>
Date: Thu, 4 Sep 2025 09:57:53 -0700
From: Bobby Eshleman <bobbyeshleman@...il.com>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: Shuah Khan <shuah@...nel.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Stefan Hajnoczi <stefanha@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Bryan Tan <bryan-bt.tan@...adcom.com>,
	Vishnu Dasa <vishnu.dasa@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	virtualization@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, linux-hyperv@...r.kernel.org,
	berrange@...hat.com, Bobby Eshleman <bobbyeshleman@...a.com>
Subject: Re: [PATCH net-next v5 4/9] vsock/loopback: add netns support

On Wed, Sep 03, 2025 at 05:10:31PM +0200, Stefano Garzarella wrote:
> On Tue, Sep 02, 2025 at 11:09:36AM -0700, Bobby Eshleman wrote:
> > On Tue, Sep 02, 2025 at 05:39:33PM +0200, Stefano Garzarella wrote:
> > > On Wed, Aug 27, 2025 at 05:31:32PM -0700, Bobby Eshleman wrote:
> > > > From: Bobby Eshleman <bobbyeshleman@...a.com>
> > > >
> > > 

[...]

> > 
> > I could be wrong here, but I think net->vsock.loopback being set before
> > vsock_core_register() prevents racing with net->vsock.loopback reads. We
> > could add a lock to make sure and to make the protection explicit
> > though.
> 
> I see, talkink about vsock_core_register(), I was thinking about,
> extending it, maybe passing a struct with all parameters (e.g. transport
> type, net callbacks, etc.). In this way we can easily check if the type
> of transport is allowed to register net callbacks or not.
> 
> Also because currently we don't do any check in
> __vsock_register_net_callbacks() about transport type or even about
> overriding calls.
> 

That makes a lot of sense. I'll make that change if pernet_operations
doesn't solve the probelem.

Best,
Bobby