netdev - Re: [PATCH net-next v28 1/1] mctp pcc: Implement MCTP over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509050150.wt57Mjwg-lkp@intel.com>
Date: Fri, 5 Sep 2025 02:25:21 +0800
From: kernel test robot <lkp@...el.com>
To: Adam Young <admiyo@...amperecomputing.com>,
	Jeremy Kerr <jk@...econstruct.com.au>,
	Matt Johnston <matt@...econstruct.com.au>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH net-next v28 1/1] mctp pcc: Implement MCTP over PCC
 Transport

Hi Adam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Adam-Young/mctp-pcc-Implement-MCTP-over-PCC-Transport/20250904-120728
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250904040544.598469-2-admiyo%40os.amperecomputing.com
patch subject: [PATCH net-next v28 1/1] mctp pcc: Implement MCTP over PCC Transport
config: i386-buildonly-randconfig-005-20250905 (https://download.01.org/0day-ci/archive/20250905/202509050150.wt57Mjwg-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250905/202509050150.wt57Mjwg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509050150.wt57Mjwg-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/mctp/mctp-pcc.c:327:6: warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
     327 |         if (rc)
         |             ^~
   drivers/net/mctp/mctp-pcc.c:303:8: note: initialize the variable 'rc' to silence this warning
     303 |         int rc;
         |               ^
         |                = 0
   1 warning generated.


vim +/rc +327 drivers/net/mctp/mctp-pcc.c

   293	
   294	static int mctp_pcc_driver_add(struct acpi_device *acpi_dev)
   295	{
   296		struct mctp_pcc_lookup_context context = {0};
   297		struct mctp_pcc_ndev *mctp_pcc_ndev;
   298		struct device *dev = &acpi_dev->dev;
   299		struct net_device *ndev;
   300		acpi_handle dev_handle;
   301		acpi_status status;
   302		char name[32];
   303		int rc;
   304	
   305		dev_dbg(dev, "Adding mctp_pcc device for HID %s\n",
   306			acpi_device_hid(acpi_dev));
   307		dev_handle = acpi_device_handle(acpi_dev);
   308		status = acpi_walk_resources(dev_handle, "_CRS", lookup_pcct_indices,
   309					     &context);
   310		if (!ACPI_SUCCESS(status)) {
   311			dev_err(dev, "FAILURE to lookup PCC indexes from CRS\n");
   312			return -EINVAL;
   313		}
   314	
   315		snprintf(name, sizeof(name), "mctppcc%d", context.inbox_index);
   316		ndev = alloc_netdev(sizeof(*mctp_pcc_ndev), name, NET_NAME_PREDICTABLE,
   317				    mctp_pcc_setup);
   318		if (!ndev)
   319			return -ENOMEM;
   320	
   321		mctp_pcc_ndev = netdev_priv(ndev);
   322	
   323		mctp_pcc_initialize_mailbox(dev, &mctp_pcc_ndev->inbox,
   324					    context.inbox_index);
   325		mctp_pcc_initialize_mailbox(dev, &mctp_pcc_ndev->outbox,
   326					    context.outbox_index);
 > 327		if (rc)
   328			goto free_netdev;
   329	
   330		mctp_pcc_ndev->outbox.client.tx_done = mctp_pcc_tx_done;
   331		mctp_pcc_ndev->acpi_device = acpi_dev;
   332		mctp_pcc_ndev->ndev = ndev;
   333		acpi_dev->driver_data = mctp_pcc_ndev;
   334	
   335		initialize_MTU(ndev);
   336	
   337		rc = mctp_register_netdev(ndev, NULL, MCTP_PHYS_BINDING_PCC);
   338		if (rc)
   339			goto free_netdev;
   340	
   341		return devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
   342	free_netdev:
   343		free_netdev(ndev);
   344		return rc;
   345	}
   346	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki