netdev - Re: [PATCH net-next 2/3] sh_eth: Convert to DEFINE_SIMPLE_DEV_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <082d5554-7dae-4ff4-bbbe-853268865025@lunn.ch>
Date: Thu, 4 Sep 2025 20:37:31 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Niklas Söderlund <niklas.soderlund@...natech.se>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] sh_eth: Convert to
 DEFINE_SIMPLE_DEV_PM_OPS()

On Thu, Sep 04, 2025 at 05:18:57PM +0200, Geert Uytterhoeven wrote:
> Convert the Renesas SuperH Ethernet driver from an open-coded dev_pm_ops
> structure to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr().  This lets
> us drop the checks for CONFIG_PM and CONFIG_PM_SLEEP without impacting
> code size, while increasing build coverage.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/net/ethernet/renesas/sh_eth.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 0516db9dc946fcdb..f16a350736e1aa04 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -3443,8 +3443,6 @@ static void sh_eth_drv_remove(struct platform_device *pdev)
>  	free_netdev(ndev);
>  }
>  
> -#ifdef CONFIG_PM
> -#ifdef CONFIG_PM_SLEEP
>  static int sh_eth_wol_setup(struct net_device *ndev)

Humm, sh_eth_wol_setup() went from conditional to always available.

Can WoL work without PM? Is the current get_wol() and set_wol()
broken?

Maybe you can take a look at this, do some testing?

It is however not strictly related to this patch, so:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew