netdev - RE: [PATCH net] net: fec: Fix possible NPD in fec_enet_phy_reset_after_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM9PR04MB8505E749166E4A2E5D7489F28803A@AM9PR04MB8505.eurprd04.prod.outlook.com>
Date: Fri, 5 Sep 2025 02:11:26 +0000
From: Wei Fang <wei.fang@....com>
To: Stefan Wahren <wahrenst@....net>
CC: "imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Christoph Niedermaier
	<cniedermaier@...electronics.com>, Richard Leitner
	<richard.leitner@...data.com>, Shenwei Wang <shenwei.wang@....com>, Clark
 Wang <xiaoning.wang@....com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: RE: [PATCH net] net: fec: Fix possible NPD in
 fec_enet_phy_reset_after_clk_enable()

> The function of_phy_find_device may return NULL, so we need to take care
> before dereferencing phy_dev.
> 
> Fixes: 64a632da538a ("net: fec: Fix phy_device lookup for
> phy_reset_after_clk_enable()")
> Signed-off-by: Stefan Wahren <wahrenst@....net>
> Cc: Christoph Niedermaier <cniedermaier@...electronics.com>
> Cc: Richard Leitner <richard.leitner@...data.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 1383918f8a3f..adf1f2bbcbb1 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2363,7 +2363,8 @@ static void
> fec_enet_phy_reset_after_clk_enable(struct net_device *ndev)
>  		 */
>  		phy_dev = of_phy_find_device(fep->phy_node);
>  		phy_reset_after_clk_enable(phy_dev);
> -		put_device(&phy_dev->mdio.dev);
> +		if (phy_dev)
> +			put_device(&phy_dev->mdio.dev);
>  	}
>  }
> 
> --
> 2.34.1

Thanks for fixing it.

Reviewed-by: Wei Fang <wei.fang@....com>