[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250905025519.58196-1-liuqiangneo@163.com>
Date: Fri, 5 Sep 2025 10:55:15 +0800
From: liuqiangneo@....com
To: anthony.l.nguyen@...el.com,
przemyslaw.kitszel@...el.com
Cc: intel-wired-lan@...ts.osuosl.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Qiang Liu <liuqiang@...inos.cn>
Subject: [PATCH] ixgbe: Remove self-assignment code
From: Qiang Liu <liuqiang@...inos.cn>
After obtaining the register value via raw_desc,
redundant self-assignment operations can be removed.
Signed-off-by: Qiang Liu <liuqiang@...inos.cn>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
index bfeef5b0b99d..6efedf04a963 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
@@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,
/* Read sync Admin Command response */
if ((hicr & IXGBE_PF_HICR_SV)) {
- for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
+ for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));
- raw_desc[i] = raw_desc[i];
- }
}
/* Read async Admin Command response */
if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) {
- for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
+ for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++)
raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));
- raw_desc[i] = raw_desc[i];
- }
}
/* Handle timeout and invalid state of HICR register */
--
2.43.0
Powered by blists - more mailing lists