netdev - Re: [PATCH v5 net-next 2/5] net: fec: add pagepool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250905185207.2285900d@kernel.org>
Date: Fri, 5 Sep 2025 18:52:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shenwei Wang <shenwei.wang@....com>
Cc: Wei Fang <wei.fang@....com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, Clark Wang
 <xiaoning.wang@....com>, Stanislav Fomichev <sdf@...ichev.me>,
 imx@...ts.linux.dev, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-imx@....com, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v5 net-next 2/5] net: fec: add pagepool_order to support
 variable page size

On Thu,  4 Sep 2025 15:34:59 -0500 Shenwei Wang wrote:
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 5a21000aca59..f046d32a62fb 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -1780,7 +1780,7 @@ fec_enet_rx_queue(struct net_device *ndev, u16 queue_id, int budget)
>  	 * These get messed up if we get called due to a busy condition.
>  	 */
>  	bdp = rxq->bd.cur;
> -	xdp_init_buff(&xdp, PAGE_SIZE, &rxq->xdp_rxq);
> +	xdp_init_buff(&xdp, (PAGE_SIZE << fep->pagepool_order), &rxq->xdp_rxq);

please drop the unnecessary parenthesis, and 

>  	while (!((status = fec16_to_cpu(bdp->cbd_sc)) & BD_ENET_RX_EMPTY)) {
>  
> @@ -1850,7 +1850,7 @@ fec_enet_rx_queue(struct net_device *ndev, u16 queue_id, int budget)
>  		 * include that when passing upstream as it messes up
>  		 * bridging applications.
>  		 */
> -		skb = build_skb(page_address(page), PAGE_SIZE);
> +		skb = build_skb(page_address(page), (PAGE_SIZE << fep->pagepool_order));

wrap the lines at 80 chars