netdev - Re: [PATCH v1 iwl-net] igc: power up PHY before link test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250906034954.82685-1-enjuk@amazon.com>
Date: Sat, 6 Sep 2025 12:49:51 +0900
From: Kohei Enju <enjuk@...zon.com>
To: <vitaly.lifshits@...el.com>
CC: <andrew+netdev@...n.ch>, <anthony.l.nguyen@...el.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <enjuk@...zon.com>,
	<intel-wired-lan@...ts.osuosl.org>, <kohei.enju@...il.com>,
	<kuba@...nel.org>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH v1 iwl-net] igc: power up PHY before link test

On Mon, 1 Sep 2025 07:36:21 +0300, Lifshits, Vitaly wrote:

>
>> ---
>>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
>>   1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index f3e7218ba6f3..ca93629b1d3a 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -2094,6 +2094,9 @@ static void igc_ethtool_diag_test(struct net_device *netdev,
>>   		netdev_info(adapter->netdev, "Offline testing starting");
>>   		set_bit(__IGC_TESTING, &adapter->state);
>>   
>> +		/* power up PHY for link test */
>> +		igc_power_up_phy_copper(&adapter->hw);
>
>I suggest moving this to igc_link_test functionn igc_diags.c as it 
>relates only to the link test.

Thank you for taking a look, Lifshits.

Now I'm considering changing only offline test path, not including
online test path.
This is because I think online test path should not trigger any
interruption and power down/up PHY may cause disruption.

So, I forgo the online path and my intention for this patch is to power
up PHY state only in offline test path.
I think introducing igc_power_up_phy_copper() in igc_link_test()
needs careful consideration in online test path.

>
>> +
>>   		/* Link test performed before hardware reset so autoneg doesn't
>>   		 * interfere with test result
>>   		 */
>
>
>Thank you for this patch.