netdev - Re: [PATCH net-next 1/2] selftests: net: replace sleeps in fcnal-test with waits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aee4ba5c-c944-4392-a6c7-6323af9274d8@gmail.com>
Date: Sat, 6 Sep 2025 20:11:20 -0600
From: David Ahern <dsahern@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] selftests: net: replace sleeps in fcnal-test
 with waits

On 9/6/25 7:21 PM, Jakub Kicinski wrote:
> fcnal-test.sh already includes lib.sh, use relevant helpers
> instead of sleeping. The first chunk is replacing sleep after
> killing background commands. All remaining ones replace
> sleep after starting nettest as a server with wait_local_port_listen.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  tools/testing/selftests/net/fcnal-test.sh | 430 +++++++++++-----------
>  1 file changed, 215 insertions(+), 215 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>