netdev - Re: [PATCH] net: ipv4: Potential null pointer dereference in cipso_v4_parsetag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhSs8fi4N1BkF+n8MQboET7sXoVbqVQuKEWB+Nxe+gf7iA@mail.gmail.com>
Date: Mon, 8 Sep 2025 10:56:49 -0400
From: Paul Moore <paul@...l-moore.com>
To: Chen Yufeng <chenyufeng@....ac.cn>
Cc: davem@...emloft.net, dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv4: Potential null pointer dereference in cipso_v4_parsetag_enum

On Mon, Sep 8, 2025 at 4:03 AM Chen Yufeng <chenyufeng@....ac.cn> wrote:
>
> While parsing CIPSO enumerated tags, secattr->flags is set to
> NETLBL_SECATTR_MLS_CAT even if secattr->attr.mls.cat is NULL.
> If subsequent code attempts to access secattr->attr.mls.cat,
> it may lead to a null pointer dereference, causing a system crash.
>
> To address this issue, we add a check to ensure that before setting
> the NETLBL_SECATTR_MLS_CAT flag, secattr->attr.mls.cat is not NULL.
>
> fixed code:
> ```
> if (secattr->attr.mls.cat)
>     secattr->flags |= NETLBL_SECATTR_MLS_CAT;
> ```
>
> This patch is similar to eead1c2ea250("netlabel: cope with NULL catmap").
>
> Signed-off-by: Chen Yufeng <chenyufeng@....ac.cn>
> ---
>  net/ipv4/cipso_ipv4.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Paul Moore <paul@...l-moore.com>

-- 
paul-moore.com