netdev - Re: [PATCHv2 1/2] bonding: don't set oif to bond dev when getting NS target destination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MW3PR15MB3913C6107F92F772D84C1750FA0CA@MW3PR15MB3913.namprd15.prod.outlook.com>
Date: Mon, 8 Sep 2025 15:55:20 +0000
From: David Wilder <wilder@...ibm.com>
To: Hangbin Liu <liuhangbin@...il.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: Jay Vosburgh <jv@...sburgh.net>, Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re:  [PATCHv2 1/2] bonding: don't set oif to bond dev when getting NS
 target destination




________________________________________
From: Hangbin Liu <liuhangbin@...il.com>
Sent: Sunday, September 7, 2025 11:28 PM
To: netdev@...r.kernel.org
Cc: Jay Vosburgh; Andrew Lunn; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni; Simon Horman; Shuah Khan; linux-kselftest@...r.kernel.org; Hangbin Liu; David Wilder
Subject: [EXTERNAL] [PATCHv2 1/2] bonding: don't set oif to bond dev when getting NS target destination


> Unlike IPv4, IPv6 routing strictly requires the source address to be valid
> on the outgoing interface. If the NS target is set to a remote VLAN interface,
> and the source address is also configured on a VLAN over a bond interface,
> setting the oif to the bond device will fail to retrieve the correct
> destination route.
>
> Fix this by not setting the oif to the bond device when retrieving the NS
> target destination. This allows the correct destination device (the VLAN
> interface) to be determined, so that bond_verify_device_path can return the
> proper VLAN tags for sending NS messages.
>
> Reported-by: David Wilder <wilder@...ibm.com>
> Closes: https://lore.kernel.org/netdev/aGOKggdfjv0cApTO@fedora/ 
> Suggested-by: Jay Vosburgh <jv@...sburgh.net>
> Fixes: 4e24be018eb9 ("bonding: add new parameter ns_targets")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>
> v2: split the patch into 2 parts, the kernel change and test update (Jay Vosburgh)
>
> ---
>  drivers/net/bonding/bond_main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 257333c88710..30cf97f4e814 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3355,7 +3355,6 @@ static void bond_ns_send_all(struct bonding *bond, struct slave *slave)
>                 /* Find out through which dev should the packet go */
>                 memset(&fl6, 0, sizeof(struct flowi6));
>                 fl6.daddr = targets[i];
> -               fl6.flowi6_oif = bond->dev->ifindex;
>
>                 dst = ip6_route_output(dev_net(bond->dev), NULL, &fl6);
>                 if (dst->error) {
> --
> 2.50.1

I verified this solves the issue with a single level of vlan tags.
Thanks for fixing this.

Tested-by: David Wilder <wilder@...ibm.com>