[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d32af8e4-0771-4674-8317-78dd1e24c95b@collabora.com>
Date: Mon, 8 Sep 2025 17:04:41 -0300
From: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
To: Rob Herring <robh@...nel.org>
Cc: airlied@...il.com, amergnat@...libre.com, andrew+netdev@...n.ch,
andrew-ct.chen@...iatek.com, angelogioacchino.delregno@...labora.com,
broonie@...nel.org, chunkuang.hu@...nel.org, ck.hu@...iatek.com,
conor+dt@...nel.org, davem@...emloft.net, dmitry.torokhov@...il.com,
edumazet@...gle.com, flora.fu@...iatek.com, houlong.wei@...iatek.com,
jeesw@...fas.com, jmassot@...labora.com, kernel@...labora.com,
krzk+dt@...nel.org, kuba@...nel.org,
kyrie.wu@...iatek.corp-partner.google.com, lgirdwood@...il.com,
linus.walleij@...aro.org, louisalexis.eyraud@...labora.com,
maarten.lankhorst@...ux.intel.com, matthias.bgg@...il.com,
mchehab@...nel.org, minghsiu.tsai@...iatek.com, mripard@...nel.org,
p.zabel@...gutronix.de, pabeni@...hat.com, sean.wang@...nel.org,
simona@...ll.ch, support.opensource@...semi.com, tiffany.lin@...iatek.com,
tzimmermann@...e.de, yunfei.dong@...iatek.com, devicetree@...r.kernel.org,
dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-sound@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 05/14] sound: dt-bindings: Convert MediaTek RT5650
codecs bindings to YAML
Rob,
On 8/22/25 12:14 PM, Rob Herring wrote:
> On Wed, Aug 20, 2025 at 02:12:53PM -0300, Ariel D'Alessandro wrote:
>> Convert the existing text-based DT bindings for Mediatek MT8173 RT5650
>> codecs to a YAML schema.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
>> ---
>> .../sound/mediatek,mt8173-rt5650.yaml | 73 +++++++++++++++++++
>> .../bindings/sound/mt8173-rt5650.txt | 31 --------
>> 2 files changed, 73 insertions(+), 31 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8173-rt5650.yaml
>> delete mode 100644 Documentation/devicetree/bindings/sound/mt8173-rt5650.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8173-rt5650.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8173-rt5650.yaml
>> new file mode 100644
>> index 0000000000000..36e4f9c4c3d62
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8173-rt5650.yaml
>> @@ -0,0 +1,73 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/mediatek,mt8173-rt5650.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Mediatek MT8173 with RT5650 codecs and HDMI via I2S
>> +
>> +maintainers:
>> + - Ariel D'Alessandro <ariel.dalessandro@...labora.com>
>> +
>> +properties:
>> + compatible:
>> + const: "mediatek,mt8173-rt5650"
>
> Drop quotes.
Ack.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + mediatek,audio-codec:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description:
>> + The phandles of rt5650 codecs and of the HDMI encoder node.
>> + minItems: 2
>> +
>> + mediatek,platform:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + The phandle of MT8173 ASoC platform.
>> +
>> + mediatek,mclk:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + The MCLK source.
>> + 0: external oscillator, MCLK = 12.288M
>> + 1: internal source from mt8173, MCLK = sampling rate * 256
>> +
>> + codec-capture:
>> + description: Subnode of rt5650 codec capture.
>> + type: object
>> +
>> + properties:
>> + sound-dai:
>> + maxItems: 1
>> + description: phandle of the CPU DAI
>> +
>> + additionalProperties: false
>> +
>> +required:
>> + - compatible
>> + - mediatek,audio-codec
>> + - mediatek,platform
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + sound: sound {
>
> Drop unused label.
Ack.
Thanks!
--
Ariel D'Alessandro
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
Powered by blists - more mailing lists