netdev - Re: [PATCH] net: ethernet: sun4i-emac: free dma descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250908132615.6a2507ed@kernel.org>
Date: Mon, 8 Sep 2025 13:26:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Conley Lee <conleylee@...mail.com>, vkoul@...nel.org
Cc: davem@...emloft.net, wens@...e.org, mripard@...nel.org,
 netdev@...r.kernel.org, dmaengine@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: sun4i-emac: free dma descriptor

On Sun,  7 Sep 2025 19:29:30 +0800 Conley Lee wrote:
> In the current implementation of the sun4i-emac driver, when using DMA to
> receive data packets, the descriptor for the current DMA request is not
> released in the rx_done_callback.

I wish you elaborated more on the reuse flag not being set :\

> Fix this by properly releasing the descriptor.
> 
> Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support")
> Signed-off-by: Conley Lee <conleylee@...mail.com>

Hi Vinod, could you TAL? Is this fix legit or there's something wrong
with how the DMA engine API is used on this platform?
https://lore.kernel.org/all/tencent_D434891410B0717BB0BDCB1434969E6EB50A@qq.com/