netdev - Re: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2plc0ui9z.fsf@gmail.com>
Date: Tue, 09 Sep 2025 09:44:40 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
Cc: Mat Martineau <martineau@...nel.org>,  Geliang Tang
 <geliang@...nel.org>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>,  Davide
 Caratti <dcaratti@...hat.com>,  Jonathan Corbet <corbet@....net>,  Shuah
 Khan <shuah@...nel.org>,  netdev@...r.kernel.org,  mptcp@...ts.linux.dev,
  linux-kernel@...r.kernel.org,  linux-doc@...r.kernel.org,
  linux-kselftest@...r.kernel.org,  stable@...r.kernel.org
Subject: Re: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type

"Matthieu Baerts (NGI0)" <matttbe@...nel.org> writes:

> This attribute is used as a signed number in the code in pm_netlink.c:
>
>   nla_put_s32(skb, MPTCP_ATTR_IF_IDX, ssk->sk_bound_dev_if))
>
> The specs should then reflect that. Note that other 'if-idx' attributes
> from the same .yaml file use a signed number as well.

Note that mptcp_pm_parse_entry has this, which should maybe be fixed at
the same time:

	u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);

https://elixir.bootlin.com/linux/v6.16.5/source/net/mptcp/pm_netlink.c#L116

>
> Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for mptcp")
> Cc: stable@...r.kernel.org
> Reviewed-by: Geliang Tang <geliang@...nel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> ---
>  Documentation/netlink/specs/mptcp_pm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/netlink/specs/mptcp_pm.yaml b/Documentation/netlink/specs/mptcp_pm.yaml
> index 02f1ddcfbf1cfd81a398dd03c52bb9f281c1aa08..d15335684ec3d6256505f2b3887ce5818eb57462 100644
> --- a/Documentation/netlink/specs/mptcp_pm.yaml
> +++ b/Documentation/netlink/specs/mptcp_pm.yaml
> @@ -256,7 +256,7 @@ attribute-sets:
>          type: u32
>        -
>          name: if-idx
> -        type: u32
> +        type: s32
>        -
>          name: reset-reason
>          type: u32