netdev - Re: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbc791a9-7b87-42a8-abba-fa63e5812008@redhat.com>
Date: Tue, 9 Sep 2025 15:21:58 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: David Wilder <wilder@...ibm.com>, netdev@...r.kernel.org
Cc: jv@...sburgh.net, pradeeps@...ux.vnet.ibm.com, pradeep@...ibm.com,
 i.maximets@....org, amorenoz@...hat.com, haliu@...hat.com
Subject: Re: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp_target

On 7/15/25 12:54 AM, David Wilder wrote:
> Replacing the definition of bond_params.arp_targets (__be32 arp_targets[])
> with:
> 
> struct bond_arp_target {
> 	__be32			target_ip;
> 	struct bond_vlan_tag	*tags;
> 	u32			flags;
> };

The above struct is going to be allocated on the stack and has 2 holes 4
bytes each.

If you change the layout as follow:

struct bond_arp_target {
 	__be32			target_ip;
 	u32			flags;
 	struct bond_vlan_tag	*tags;
};

the struct size will be 8 bytes less.

/P