netdev - Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: remove chip->evcap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509101826.aERYSElG-lkp@intel.com>
Date: Wed, 10 Sep 2025 18:55:04 +0800
From: kernel test robot <lkp@...el.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Andrew Lunn <andrew@...n.ch>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>,
	Richard Cochran <richardcochran@...il.com>,
	Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 3/4] net: dsa: mv88e6xxx: remove
 chip->evcap_config

Hi Russell,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-dsa-mv88e6xxx-remove-mv88e6250_ptp_ops/20250910-034838
base:   net-next/main
patch link:    https://lore.kernel.org/r/E1uw0Xk-00000004IOC-1EJd%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next 3/4] net: dsa: mv88e6xxx: remove chip->evcap_config
config: i386-buildonly-randconfig-004-20250910 (https://download.01.org/0day-ci/archive/20250910/202509101826.aERYSElG-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250910/202509101826.aERYSElG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509101826.aERYSElG-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/dsa/mv88e6xxx/ptp.c:182:2: error: use of undeclared identifier 'evcap_config'; did you mean 'evap_config'?
     182 |         evcap_config = MV88E6XXX_TAI_CFG_CAP_OVERWRITE |
         |         ^~~~~~~~~~~~
         |         evap_config
   drivers/net/dsa/mv88e6xxx/ptp.c:178:6: note: 'evap_config' declared here
     178 |         u16 evap_config;
         |             ^
   drivers/net/dsa/mv88e6xxx/ptp.c:185:3: error: use of undeclared identifier 'evcap_config'; did you mean 'evap_config'?
     185 |                 evcap_config |= MV88E6XXX_TAI_CFG_EVREQ_FALLING;
         |                 ^~~~~~~~~~~~
         |                 evap_config
   drivers/net/dsa/mv88e6xxx/ptp.c:178:6: note: 'evap_config' declared here
     178 |         u16 evap_config;
         |             ^
   drivers/net/dsa/mv88e6xxx/ptp.c:187:53: error: use of undeclared identifier 'evcap_config'; did you mean 'evap_config'?
     187 |         err = mv88e6xxx_tai_write(chip, MV88E6XXX_TAI_CFG, evcap_config);
         |                                                            ^~~~~~~~~~~~
         |                                                            evap_config
   drivers/net/dsa/mv88e6xxx/ptp.c:178:6: note: 'evap_config' declared here
     178 |         u16 evap_config;
         |             ^
   3 errors generated.


vim +182 drivers/net/dsa/mv88e6xxx/ptp.c

   168	
   169	/* mv88e6352_config_eventcap - configure TAI event capture
   170	 * @event: PTP_CLOCK_PPS (internal) or PTP_CLOCK_EXTTS (external)
   171	 * @rising: zero for falling-edge trigger, else rising-edge trigger
   172	 *
   173	 * This will also reset the capture sequence counter.
   174	 */
   175	static int mv88e6352_config_eventcap(struct mv88e6xxx_chip *chip, int event,
   176					     int rising)
   177	{
   178		u16 evap_config;
   179		u16 cap_config;
   180		int err;
   181	
 > 182		evcap_config = MV88E6XXX_TAI_CFG_CAP_OVERWRITE |
   183			       MV88E6XXX_TAI_CFG_CAP_CTR_START;
   184		if (!rising)
   185			evcap_config |= MV88E6XXX_TAI_CFG_EVREQ_FALLING;
   186	
   187		err = mv88e6xxx_tai_write(chip, MV88E6XXX_TAI_CFG, evcap_config);
   188		if (err)
   189			return err;
   190	
   191		if (event == PTP_CLOCK_PPS) {
   192			cap_config = MV88E6XXX_TAI_EVENT_STATUS_CAP_TRIG;
   193		} else if (event == PTP_CLOCK_EXTTS) {
   194			/* if STATUS_CAP_TRIG is unset we capture PTP_EVREQ events */
   195			cap_config = 0;
   196		} else {
   197			return -EINVAL;
   198		}
   199	
   200		/* Write the capture config; this also clears the capture counter */
   201		err = mv88e6xxx_tai_write(chip, MV88E6XXX_TAI_EVENT_STATUS,
   202					  cap_config);
   203	
   204		return err;
   205	}
   206	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki