netdev - Re: [PATCHv3 net 2/3] hsr: use hsr_for_each_port_rtnl in hsr_port_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250910170758.GC30363@horms.kernel.org>
Date: Wed, 10 Sep 2025 18:07:58 +0100
From: Simon Horman <horms@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	MD Danish Anwar <danishanwar@...com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Jaakko Karrenpalo <jkarrenpalo@...il.com>,
	Fernando Fernandez Mancera <ffmancera@...eup.net>,
	Murali Karicheri <m-karicheri2@...com>,
	WingMan Kwok <w-kwok2@...com>, Stanislav Fomichev <sdf@...ichev.me>,
	Xiao Liang <shaw.leon@...il.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCHv3 net 2/3] hsr: use hsr_for_each_port_rtnl in
 hsr_port_get_hsr

On Fri, Sep 05, 2025 at 09:15:32AM +0000, Hangbin Liu wrote:
> hsr_port_get_hsr() iterates over ports using hsr_for_each_port(),
> but many of its callers do not hold the required RCU lock.
> 
> Switch to hsr_for_each_port_rtnl(), since most callers already hold
> the rtnl lock. After review, all callers are covered by either the rtnl
> lock or the RCU lock, except hsr_dev_xmit(). Fix this by adding an
> RCU read lock there.
> 
> Fixes: c5a759117210 ("net/hsr: Use list_head (and rcu) instead of array for slave devices.")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Thanks,

I agree with your analysis.

Reviewed-by: Simon Horman <horms@...nel.org>

...