netdev - Re: [PATCHv2 2/2] selftests: bonding: add vlan over bond testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250909192606.6ac53aa4@kernel.org>
Date: Tue, 9 Sep 2025 19:26:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCHv2 2/2] selftests: bonding: add vlan over bond testing

On Wed, 10 Sep 2025 02:03:52 +0000 Hangbin Liu wrote:
> On Tue, Sep 09, 2025 at 04:46:00PM -0700, Jakub Kicinski wrote:
> > On Mon,  8 Sep 2025 06:28:02 +0000 Hangbin Liu wrote:  
> > > Add a vlan over bond testing to make sure arp/ns target works.
> > > Also change all the configs to mudules.  
> > 
> > Why are you switching everything to module?
> > The series needs to go to net, we should avoid unnecessary cleanups.
> > And I think changing the config is unrelated to the selftest so it
> > should be a standalone patch in the first place?  
> 
> On my local testing, there will be a lot default interfaces if all modules
> build in. This could make the test environment more clean.
> But it's just my preference.

No strong opinion on my side. Your point is fair. On the other hand
sometimes dealing with modules is tricky (especially with vng when
building kernel with O=build/). But not sure how much we should care
about shortcomings of tooling which can be fixed. It's okay for our CI.

> As you said, we can do it with a stand alone
> patch. I will re-post and drop the config update.

Yup! For net we should avoid it.