netdev - Re: [RFC PATCH bpf-next 11/14] bpf: Introduce BPF_SOCK_OPS_UDP_CONNECTED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aqvluk774lxbko2znaeozteef246mcvwd4qhvcqsqahr5zdmyw@kmbefshxxm53>
Date: Wed, 10 Sep 2025 14:41:16 -0700
From: Jordan Rife <jordan@...fe.io>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Stanislav Fomichev <sdf@...ichev.me>, 
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, Aditi Ghag <aditi.ghag@...valent.com>
Subject: Re: [RFC PATCH bpf-next 11/14] bpf: Introduce
 BPF_SOCK_OPS_UDP_CONNECTED_CB

> >         res = __ip4_datagram_connect(sk, uaddr, addr_len);
> >         if (!res)
> >                 udp4_hash4(sk);
> > +       udp_call_bpf(sk, BPF_SOCK_OPS_UDP_CONNECTED_CB);
> 
> Why is this called on failure ?
> 
> Same for IPv6.

My mistake, it should only be called on success.

	if (!res) {
		udp4_hash4(sk);
		udp_call_bpf(sk, BPF_SOCK_OPS_UDP_CONNECTED_CB);
	}

I'll fix this in a later revision.

Jordan