netdev - Re: [iwl-next] ice, irdma: Add rdma_qp_limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d327a0-72d3-4775-8842-6c4ceaff41e2@intel.com>
Date: Wed, 10 Sep 2025 09:41:14 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Leon Romanovsky <leon@...nel.org>, Tatyana Nikolova
	<tatyana.e.nikolova@...el.com>, <jiri@...nulli.us>
CC: <intel-wired-lan@...ts.osuosl.org>, <linux-rdma@...r.kernel.org>,
	<netdev@...r.kernel.org>, <anthony.l.nguyen@...el.com>, Jakub Kicinski
	<kuba@...nel.org>, Mohammad Heib <mheib@...hat.com>
Subject: Re: [iwl-next] ice, irdma: Add rdma_qp_limits_sel devlink parameter
 for irdma

On 9/9/25 14:20, Leon Romanovsky wrote:
> On Thu, Sep 04, 2025 at 02:57:19PM -0500, Tatyana Nikolova wrote:
>> Add a devlink parameter to switch between different QP resource profiles
>> (max number of QPs) supported by irdma for Intel Ethernet 800 devices. The
>> rdma_qp_limits_sel is translated into an index in the rsrc_limits_table to
>> select a power of two number between 1 and 256 for max supported QPs (1K-256K).
>> To reduce the irdma memory footprint, set the rdma_qp_limits_sel default value
>> to 1 (max 1K QPs).
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@...el.com>
>> ---
>> Since the changes to irdma are minor, this is targeted to iwl-next/net-next.
> 
> <...>
> 
>>   #define DEVLINK_LOCAL_FWD_DISABLED_STR "disabled"
>>   #define DEVLINK_LOCAL_FWD_ENABLED_STR "enabled"
>>   #define DEVLINK_LOCAL_FWD_PRIORITIZED_STR "prioritized"
>> @@ -1621,6 +1723,7 @@ enum ice_param_id {
>>   	ICE_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX,
>>   	ICE_DEVLINK_PARAM_ID_TX_SCHED_LAYERS,
>>   	ICE_DEVLINK_PARAM_ID_LOCAL_FWD,
>> +	ICE_DEVLINK_PARAM_ID_RDMA_QP_LIMITS_SEL,
>>   };
> 
> I was under impression that driver-specific devlink knobs are not
> allowed. Was this limitation changed for Intel?

I'm not aware of such limitation.
It's always better to have generic params, but some knobs are not likely
to be reused; anyway it would be easy to convert into generic.

To have this particular param more generic-ready, we have converted from
our internal format (values were 0...7, mapped into some powers of two)
to what one could imagine other drivers would like to add at some point
(perhaps multiplying the user-provided value by 1K is unnecessarily
complicating adoption for small NICs, IDK?).

Do you believe this should be switched to generic now (instead of when
there is a future user)?
What about a name (this should be kept forever)?

side note:
We are also going to add yet another param, now used only by intel, but
we do so as a generic one: "max number of MAC addrs for VF in i40e", see
https://lore.kernel.org/intel-wired-lan/20250907100454.193420-1-mheib@redhat.com/T/#t


> 
> Thanks