netdev - Re: [PATCH net-next] page_pool: always add GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250910175240.72c56e86@kernel.org>
Date: Wed, 10 Sep 2025 17:52:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: davem@...emloft.net, hawk@...nel.org
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, ilias.apalodimas@...aro.org,
 nathan@...nel.org, nick.desaulniers+lkml@...il.com, morbo@...gle.com,
 justinstitt@...gle.com, llvm@...ts.linux.dev
Subject: Re: [PATCH net-next] page_pool: always add GFP_NOWARN for ATOMIC
 allocations

On Mon,  8 Sep 2025 08:21:23 -0700 Jakub Kicinski wrote:
> Driver authors often forget to add GFP_NOWARN for page allocation
> from the datapath. This is annoying to operators as OOMs are a fact
> of life, and we pretty much expect network Rx to hit page allocation
> failures during OOM. Make page pool add GFP_NOWARN for ATOMIC allocations
> by default.

Hi Jesper! Are you okay with this? It's not a lot of instructions and
it's in the _slow() function, anyway. TBH I wrote the patch to fix the
driver (again) first but when writing the commit message I realized my
explanation why we can't fix this in the core was sounding like BS :$