netdev - Re: [PATCH net-next 4/5] netconsole: resume previously deactivated target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nvbscfpi75on4pkv5niyzxkheobyxqofju7lr5a6kfywssgedj@tn4cgo4zj3qc>
Date: Thu, 11 Sep 2025 09:05:27 +0100
From: Andre Carvalho <asantostc@...il.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 4/5] netconsole: resume previously deactivated
 target

On Wed, Sep 10, 2025 at 12:50:07PM -0700, Breno Leitao wrote:
> > +		if (nt->state == STATE_DEACTIVATED && event == NETDEV_UP)  {
> > +			if (!strncmp(nt->np.dev_name, dev->name, IFNAMSIZ))
> 
> Don't you need to check for dev_mac here as well?

I believe so. Will fix that and try to cover this case on the selftest too.

> > +				schedule_work(&nt->resume_wq);
> 
> I would prefer to have the enablement done inline here, instead of
> scheduling a task.

That makes sense. I believe I'll need an alternative to netpoll_setup that can be 
called with rtnl already held. I'll attempt to do this for v2.

Thanks for the review!