netdev - Re: [PATCH 14/32] net: use ns_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250911-unqualifiziert-widmen-03b0c271aa69@brauner>
Date: Thu, 11 Sep 2025 10:46:11 +0200
From: Christian Brauner <brauner@...nel.org>
To: Jan Kara <jack@...e.cz>
Cc: Amir Goldstein <amir73il@...il.com>, linux-fsdevel@...r.kernel.org, 
	Josef Bacik <josef@...icpanda.com>, Jeff Layton <jlayton@...nel.org>, Mike Yuan <me@...dnzj.com>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>, Lennart Poettering <mzxreary@...inter.de>, 
	Daan De Meyer <daan.j.demeyer@...il.com>, Aleksa Sarai <cyphar@...har.com>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný <mkoutny@...e.com>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Chuck Lever <chuck.lever@...cle.com>, linux-nfs@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH 14/32] net: use ns_common_init()

On Wed, Sep 10, 2025 at 05:57:52PM +0200, Jan Kara wrote:
> On Wed 10-09-25 16:36:59, Christian Brauner wrote:
> > Don't cargo-cult the same thing over and over.
> > 
> > Signed-off-by: Christian Brauner <brauner@...nel.org>
> 
> One comment below.
> 
> > @@ -812,17 +828,14 @@ static void net_ns_net_debugfs(struct net *net)
> >  
> >  static __net_init int net_ns_net_init(struct net *net)
> >  {
> > -#ifdef CONFIG_NET_NS
> > -	net->ns.ops = &netns_operations;
> > -#endif
> > -	net->ns.inum = PROC_NET_INIT_INO;
> > -	if (net != &init_net) {
> > -		int ret = ns_alloc_inum(&net->ns);
> > -		if (ret)
> > -			return ret;
> > -	}
> > +	int ret = 0;
> > +
> > +	if (net == &init_net)
> > +		net->ns.inum = PROC_NET_INIT_INO;
> > +	else
> > +		ret = proc_alloc_inum(&to_ns_common(net)->inum);
> >  	net_ns_net_debugfs(net);
> 
> Here you're calling net_ns_net_debugfs() even if proc_alloc_inum() failed
> which looks like a bug to me...

Yes, good catch!

Fyi, I have been out properly sick this week and that's why I haven't
been very active on-list. I hope to be back in a more functional state
tomorrow and will process the backlog.