netdev - Re: [PATCHv3 net 0/3] hsr: fix lock warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175758481000.2111220.9133355374443467875.git-patchwork-notify@kernel.org>
Date: Thu, 11 Sep 2025 10:00:10 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, danishanwar@...com,
 aleksander.lobakin@...el.com, jkarrenpalo@...il.com, ffmancera@...eup.net,
 m-karicheri2@...com, w-kwok2@...com, sdf@...ichev.me, shaw.leon@...il.com,
 kuniyu@...gle.com, johannes.berg@...el.com
Subject: Re: [PATCHv3 net 0/3] hsr: fix lock warnings

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Fri,  5 Sep 2025 09:15:30 +0000 you wrote:
> hsr_for_each_port is called in many places without holding the RCU read
> lock, this may trigger warnings on debug kernels like:
> 
>   [   40.457015] [  T201] WARNING: suspicious RCU usage
>   [   40.457020] [  T201] 6.17.0-rc2-virtme #1 Not tainted
>   [   40.457025] [  T201] -----------------------------
>   [   40.457029] [  T201] net/hsr/hsr_main.c:137 RCU-list traversed in non-reader section!!
>   [   40.457036] [  T201]
>                           other info that might help us debug this:
> 
> [...]

Here is the summary with links:
  - [PATCHv3,net,1/3] hsr: use rtnl lock when iterating over ports
    https://git.kernel.org/netdev/net/c/8884c6939913
  - [PATCHv3,net,2/3] hsr: use hsr_for_each_port_rtnl in hsr_port_get_hsr
    https://git.kernel.org/netdev/net/c/393c841fe433
  - [PATCHv3,net,3/3] hsr: hold rcu and dev lock for hsr_get_port_ndev
    https://git.kernel.org/netdev/net/c/847748fc66d0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html