netdev - [PATCH net] net: ena: fix duplicate Autoneg setting in get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250911113727.3857978-1-alok.a.tiwari@oracle.com>
Date: Thu, 11 Sep 2025 04:37:20 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: shayagr@...zon.com, akiyano@...zon.com, saeedb@...zon.com,
        darinzon@...zon.com, andrew+netdev@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        horms@...nel.org, netdev@...r.kernel.org
Cc: alok.a.tiwari@...cle.com
Subject: [PATCH net] net: ena: fix duplicate Autoneg setting in get_link_ksettings

The ENA ethtool implementation mistakenly sets the Autoneg link mode
twice in the 'supported' mask, leaving the 'advertising mask unset.

Fix this by setting Autoneg in 'advertising' instead of duplicating
it in 'supported'.

Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
---
 drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
index a81d3a7a3bb9..a6ef12c157ca 100644
--- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
+++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
@@ -471,7 +471,7 @@ static int ena_get_link_ksettings(struct net_device *netdev,
 		ethtool_link_ksettings_add_link_mode(link_ksettings,
 						     supported, Autoneg);
 		ethtool_link_ksettings_add_link_mode(link_ksettings,
-						     supported, Autoneg);
+						     advertising, Autoneg);
 	}
 
 	link_ksettings->base.autoneg =
-- 
2.50.1