netdev - Re: [PATCH v2] net: phy: micrel: Update Kconfig help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74a34c78-fed8-4438-9a9e-027d4a4762a7@lunn.ch>
Date: Thu, 11 Sep 2025 14:38:31 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jonas Rebmann <jre@...gutronix.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: phy: micrel: Update Kconfig help text

On Thu, Sep 11, 2025 at 10:29:03AM +0200, Jonas Rebmann wrote:
> This driver by now supports 17 different Microchip (formerly known as
> Micrel) chips: KSZ9021, KSZ9031, KSZ9131, KSZ8001, KS8737, KSZ8021,
> KSZ8031, KSZ8041, KSZ8051, KSZ8061, KSZ8081, KSZ8873MLL, KSZ886X,
> KSZ9477, LAN8814, LAN8804 and LAN8841.
> 
> Support for the VSC8201 was removed in commit 51f932c4870f ("micrel phy
> driver - updated(1)")
> 
> Update the help text to reflect that, list families instead of models to
> ease future maintenance.
> 
> Signed-off-by: Jonas Rebmann <jre@...gutronix.de>
> ---
> Changes in v2:
> - Don't capitalize "micrel" in commit message (Thanks, Jakub)
> - Name chip families with the common xxx-placeholders (Thanks, Jakub)
> - Be a bit more specific as to which families
> - Link to v1: https://lore.kernel.org/r/20250909-micrel-kconfig-v1-1-22d04bb90052@pengutronix.de
> ---
>  drivers/net/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index a7fb1d7cae94..e543eef36d98 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -298,7 +298,7 @@ config MICREL_PHY
>  	depends on PTP_1588_CLOCK_OPTIONAL
>  	select PHY_PACKAGE
>  	help
> -	  Supports the KSZ9021, VSC8201, KS8001 PHYs.
> +	  Supports the KSZ8xxx, KSZ9xxx, and LAN88xx families of Micrel/Microchip PHYs.

Much better, thanks.

> Best regards,
> --  
> Jonas Rebmann <jre@...gutronix.de>

It is a bit unusual to see a signature, git send-email, or b4 send
would not do that. But patch(1) should be able to figure this out.

For future reference, the Subject line should have the tree inside the
[].

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew