netdev - Re: [PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp bindings to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4a18a08-516a-4a0b-a477-1e9f5269f1d8@collabora.com>
Date: Thu, 11 Sep 2025 10:38:23 -0300
From: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: airlied@...il.com, amergnat@...libre.com, andrew+netdev@...n.ch,
 andrew-ct.chen@...iatek.com, angelogioacchino.delregno@...labora.com,
 broonie@...nel.org, chunkuang.hu@...nel.org, ck.hu@...iatek.com,
 conor+dt@...nel.org, davem@...emloft.net, dmitry.torokhov@...il.com,
 edumazet@...gle.com, flora.fu@...iatek.com, houlong.wei@...iatek.com,
 jeesw@...fas.com, jmassot@...labora.com, kernel@...labora.com,
 krzk+dt@...nel.org, kuba@...nel.org,
 kyrie.wu@...iatek.corp-partner.google.com, lgirdwood@...il.com,
 linus.walleij@...aro.org, louisalexis.eyraud@...labora.com,
 maarten.lankhorst@...ux.intel.com, matthias.bgg@...il.com,
 mchehab@...nel.org, minghsiu.tsai@...iatek.com, mripard@...nel.org,
 p.zabel@...gutronix.de, pabeni@...hat.com, robh@...nel.org,
 sean.wang@...nel.org, simona@...ll.ch, support.opensource@...semi.com,
 tiffany.lin@...iatek.com, tzimmermann@...e.de, yunfei.dong@...iatek.com,
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-sound@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v1 01/14] media: dt-bindings: Convert MediaTek mt8173-mdp
 bindings to YAML

Krzysztof,

On 9/9/25 3:32 AM, Krzysztof Kozlowski wrote:
> On 08/09/2025 19:52, Ariel D'Alessandro wrote:
>> Krzysztof,
>>
>> On 8/21/25 3:46 AM, Krzysztof Kozlowski wrote:
>>> On Wed, Aug 20, 2025 at 02:12:49PM -0300, Ariel D'Alessandro wrote:

[...]

>>>> +          - enum:
>>>> +              - mediatek,mt8173-mdp-rdma
>>>> +              - mediatek,mt8173-mdp-rsz
>>>> +              - mediatek,mt8173-mdp-wdma
>>>> +              - mediatek,mt8173-mdp-wrot
>>>> +      - items:
>>>> +          - enum:
>>>> +              - mediatek,mt8173-mdp-rdma
>>>> +              - mediatek,mt8173-mdp-rsz
>>>> +              - mediatek,mt8173-mdp-wdma
>>>> +              - mediatek,mt8173-mdp-wrot
>>>> +          - const: mediatek,mt8173-mdp
>>>
>>> This makes no sense. How devices can be compatible and can not be
>>> compatible.
>>
>> According to the driver source code (and the previous txt mt8173-mdp
>> bindings), there must be a "controller node" with compatible
>> `mediatek,mt8173-mdp`. Then its sibling nodes (including itself) should
> 
> But you did not define "mediatek,mt8173-mdp" here, so what are you
> talking about?
> 
> I talk here about "wrot" and others, I thought it is obvious from the
> mistake in the schema.

Ack.

[...]

>>>> +
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            const: mediatek,mt8173-mdp
>>>
>>> This makes no sense either.
>>
>> Same question above about compatibles.
> 
> How same question? Do you understand this code? It is nothing the same -
> you have here contains!


Ack. Will resubmit properly in v2.

Thanks,

-- 
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK 
Registered in England & Wales, no. 5513718