netdev - Re: [PATCH net v2] octeon_ep: Validate the VF ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aML_a9kUmuv48r6H@lima-fedora>
Date: Thu, 11 Sep 2025 12:57:15 -0400
From: Kamal Heib <kheib@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Veerasenareddy Burru <vburru@...vell.com>,
	Sathesh Edara <sedara@...vell.com>,
	Shinas Rasheed <srasheed@...vell.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Subject: Re: [PATCH net v2] octeon_ep: Validate the VF ID

On Wed, Sep 10, 2025 at 07:26:58PM -0700, Jakub Kicinski wrote:
> On Tue,  9 Sep 2025 09:10:20 -0400 Kamal Heib wrote:
> > +static bool octep_is_vf_valid(struct octep_device *oct, int vf)
> > +{
> > +	if (vf >= CFG_GET_ACTIVE_VFS(oct->conf)) {
> > +		dev_err(&oct->pdev->dev, "Invalid VF ID %d\n", vf);
> > +		return false;
> 
> perhaps a nit, but why did you choose dev_err() over netdev_err()?
> The incoming handle is a netdev.

Thanks for your review.

I believe I saw one of the ethernet drivers using dev_err() instead of
netdev_err(), but I agree with you. I'll change it to netdev_err().