netdev - Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fa3078a-1ebc-47a3-88a1-1b8713acba12@kernel.org>
Date: Thu, 11 Sep 2025 20:16:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>, Andrew Lunn <andrew@...n.ch>
Cc: Russell King - ARM Linux <linux@...linux.org.uk>,
 Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style
 fixed-link binding is used

On 11/09/2025 18:58, Heiner Kallweit wrote:
> On 9/11/2025 6:44 PM, Andrew Lunn wrote:
>> On Thu, Sep 11, 2025 at 06:28:03PM +0200, Heiner Kallweit wrote:
>>> On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
>>>> On 09/09/2025 21:16, Heiner Kallweit wrote:
>>>>> The array-style fixed-link binding has been marked deprecated for more
>>>>> than 10 yrs, but still there's a number of users. Print a warning when
>>>>> usage of the deprecated binding is detected.
>>>>>
>>>>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>>>>> ---
>>>>>  drivers/net/phy/phylink.c | 3 +++
>>>>>  1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>>>>> index c7f867b36..d3cb52717 100644
>>>>> --- a/drivers/net/phy/phylink.c
>>>>> +++ b/drivers/net/phy/phylink.c
>>>>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>>>>>  			return -EINVAL;
>>>>>  		}
>>>>>  
>>>>> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
>>>>> +			     fwnode_get_name(fwnode));
>>>> Similar comment as for patch #1 - this seems to be going to printk, so
>>>> use proper % format for fwnodes (I think there is as well such).
>>>>
>>> At least here no format for fwnodes is mentioned.
>>> https://www.kernel.org/doc/Documentation/printk-formats.txt
No, you are looking at wrong file.

It is Documentation/core-api/printk-formats.rst

Best regards,
Krzysztof