netdev - Re: [External] : Re: [PATCH net] net: ena: fix duplicate Autoneg setting in get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30acdf24-c945-40ff-b7f8-29a5b2c0c3e5@lunn.ch>
Date: Thu, 11 Sep 2025 22:14:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>
Cc: shayagr@...zon.com, akiyano@...zon.com, saeedb@...zon.com,
	darinzon@...zon.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, netdev@...r.kernel.org
Subject: Re: [External] : Re: [PATCH net] net: ena: fix duplicate Autoneg
 setting in get_link_ksettings

> So we have two possible approaches:
> 1. Explicitly set supported unconditionally and gate advertising on the
> flag:
> 
> /* Autoneg is always supported */
> ethtool_link_ksettings_add_link_mode(link_ksettings, supported, Autoneg);
> 
> if (link->flags & ENA_ADMIN_GET_FEATURE_LINK_DESC_AUTONEG_MASK)
>         ethtool_link_ksettings_add_link_mode(link_ksettings, advertising,
> Autoneg);

This is the correct change.

	Andrew