[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d5b7afbf-318a-49c8-9e40-bcb4b452201b@gmail.com>
Date: Thu, 11 Sep 2025 14:50:53 -0600
From: David Ahern <dsahern@...il.com>
To: Jamal Hadi Salim <jhs@...atatu.com>,
Jay Vosburgh <jay.vosburgh@...onical.com>
Cc: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] tc/police: Allow 64 bit burst size
On 9/9/25 9:32 PM, Jamal Hadi Salim wrote:
>
> Please run tdc tests. David/Stephen - can we please make this a
> requirement for iproute2 tc related changes?
I will try to remember to run tdc tests for tc patches. Without an
automated setup, there will be misses over time.
>
> Jay, your patches fail at least one test because you changed the unit outputs.
> Either we fix the tdc test or you make your changes backward compatible.
> In the future also cc kernel tc maintainers (I only saw this because
> someone pointed it to me).
> Overall the changes look fine.
Sent a patch to add a tc entry to iproute2 maintainers file.
You say the change looks fine but at least one test fails meaning
changes are requested?
Powered by blists - more mailing lists