netdev - [PATCH v1 net 0/8] net: Fix UAF of sk_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250911030620.1284754-1-kuniyu@google.com>
Date: Thu, 11 Sep 2025 03:05:28 +0000
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...gle.com>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: [PATCH v1 net 0/8] net: Fix UAF of sk_dst_get(sk)->dev.

syzbot caught use-after-free of sk_dst_get(sk)->dev,
which was not fetched under RCU nor RTNL. [0]

Patch 1 adds 2 helpers to fetch __sk_dst_get(sk)->dev safely
Patch 2 ~ 8 fix UAF in smc, tcp, ktls, mptcp

[0]: https://lore.kernel.org/netdev/68c237c7.050a0220.3c6139.0036.GAE@google.com/

Kuniyuki Iwashima (8):
  net: Add sk_dst_dev_rcu() and sk_dst_dev_get().
  smc: Fix use-after-free in __pnet_find_base_ndev().
  smc: Use sk_dst_dev_rcu() in in smc_clc_prfx_set().
  smc: Use sk_dst_dev_rcu() in smc_clc_prfx_match().
  smc: Use sk_dst_dev_rcu() in smc_vlan_by_tcpsk().
  tcp: Use sk_dst_dev_rcu() in tcp_fastopen_active_disable_ofo_check().
  tls: Use sk_dst_dev_rcu() in get_netdev_for_sock().
  mptcp: Use sk_dst_dev_rcu() in mptcp_active_enable().

 include/net/sock.h      | 19 +++++++++++++
 net/ipv4/tcp_fastopen.c |  7 ++---
 net/mptcp/ctrl.c        |  7 +++--
 net/smc/smc_clc.c       | 63 ++++++++++++++++++++---------------------
 net/smc/smc_core.c      | 25 +++++++---------
 net/smc/smc_pnet.c      | 35 ++++++++---------------
 net/tls/tls_device.c    | 16 +++++------
 7 files changed, 88 insertions(+), 84 deletions(-)

-- 
2.51.0.384.g4c02a37b29-goog