netdev - Re: [PATCH net-next 1/2] of: mdio: warn if deprecated fixed-link binding is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7c6da2e-5ae5-497b-977b-b232793172a9@kernel.org>
Date: Thu, 11 Sep 2025 08:34:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] of: mdio: warn if deprecated fixed-link
 binding is used

On 09/09/2025 21:15, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/mdio/of_mdio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
> index d8ca63ed8..d35e28dbe 100644
> --- a/drivers/net/mdio/of_mdio.c
> +++ b/drivers/net/mdio/of_mdio.c
> @@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np)
>  	/* Old binding */
>  	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
>  				       ARRAY_SIZE(fixed_link_prop)) == 0) {
> +		pr_warn_once("%s uses deprecated array-style fixed-link binding!",

Please use proper % format specifier for nodes. See printk-formats.

> +			     of_node_full_name(np));
Best regards,
Krzysztof