netdev - Re: [PATCH v2 iwl-net] igc: don't fail igc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <995b4ae2-2163-4618-84de-63548c7e2633@intel.com>
Date: Thu, 11 Sep 2025 10:04:24 +0300
From: "Lifshits, Vitaly" <vitaly.lifshits@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, Kohei Enju
	<enjuk@...zon.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Kurt Kanzenbach
	<kurt@...utronix.de>, "kohei.enju@...il.com" <kohei.enju@...il.com>
Subject: Re: [PATCH v2 iwl-net] igc: don't fail igc_probe() on LED setup error

On 9/11/2025 9:36 AM, Loktionov, Aleksandr wrote:
> 
> 
>> -----Original Message-----
>> From: Kohei Enju <enjuk@...zon.com>
>> Sent: Wednesday, September 10, 2025 3:47 PM
>> To: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
>> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
>> Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn
>> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
>> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
>> Abeni <pabeni@...hat.com>; Kurt Kanzenbach <kurt@...utronix.de>;
>> Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Lifshits, Vitaly
>> <vitaly.lifshits@...el.com>; kohei.enju@...il.com; Kohei Enju
>> <enjuk@...zon.com>
>> Subject: [PATCH v2 iwl-net] igc: don't fail igc_probe() on LED setup
>> error
>>
> 
> ...
> 
>>
>>   FAILSLAB_PATH=/sys/kernel/debug/failslab/
>>   DEVICE=0000:00:05.0
>>   START_ADDR=$(grep " igc_led_setup" /proc/kallsyms \
>>           | awk '{printf("0x%s", $1)}')
>>   END_ADDR=$(printf "0x%x" $((START_ADDR + 0x100)))
>>
>>   echo $START_ADDR > $FAILSLAB_PATH/require-start
>>   echo $END_ADDR > $FAILSLAB_PATH/require-end
>>   echo 1 > $FAILSLAB_PATH/times
>>   echo 100 > $FAILSLAB_PATH/probability
>>   echo N > $FAILSLAB_PATH/ignore-gfp-wait
>>
>>   echo $DEVICE > /sys/bus/pci/drivers/igc/bind
>>
> Using fault-injection test using failslab - excellent!
> 
>> Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226")
>> Signed-off-by: Kohei Enju <enjuk@...zon.com>
>> ---
>> Changes:
>>    v1->v2:
>>      - don't fail probe when led setup fails
>>      - rephrase subject and commit message
>>    v1: https://lore.kernel.org/intel-wired-lan/20250906055239.29396-1-
>> enjuk@...zon.com/
>> ---
> 
> ...
> 
>   
>>   	/* Release control of h/w to f/w.  If f/w is AMT enabled, this
>> --
>> 2.48.1
> 
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

Reviewed-by: Vitaly Lifshits <vitaly.lifshits@...el.com>