netdev - [PATCH RFC net 1/1] net/bonding: add 0 to the range of arp_missed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912091635.3577586-1-pradyumn.rahar@oracle.com>
Date: Fri, 12 Sep 2025 09:16:35 +0000
From: Pradyumn Rahar <pradyumn.rahar@...cle.com>
To: linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org, jv@...sburgh.net,
        andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Cc: pradyumn.rahar@...cle.com, anand.a.khoje@...cle.com,
        rama.nichanamatlu@...cle.com, manjunath.b.patil@...cle.com,
        rajesh.sivaramasubramaniom@...cle.com
Subject: [PATCH RFC net 1/1] net/bonding: add 0 to the range of arp_missed_max

NetworkManager uses 0 to indicate that the option `arp_missed_max`
is in unset state as this option is not compatible with 802.3AD,
balance-tlb and balance-alb modes.

This causes kernel to report errors like this:

kernel: backend0: option arp_missed_max: invalid value (0)
kernel: backend0: option arp_missed_max: allowed values 1 - 255
NetworkManager[1766]: <error> [1757489103.9525] platform-linux: sysctl: failed to set 'bonding/arp_missed_max' to '0': (22) Invalid argument
NetworkManager[1766]: <warn>  [1757489103.9525] device (backend0): failed to set bonding attribute 'arp_missed_max' to '0'

when NetworkManager tries to set this value to 0

Signed-off-by: Pradyumn Rahar <pradyumn.rahar@...cle.com>
---
 drivers/net/bonding/bond_options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 3b6f815c55ff..243fde3caecd 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -230,7 +230,7 @@ static const struct bond_opt_value bond_ad_user_port_key_tbl[] = {
 };
 
 static const struct bond_opt_value bond_missed_max_tbl[] = {
-	{ "minval",	1,	BOND_VALFLAG_MIN},
+	{ "minval",	0,	BOND_VALFLAG_MIN},
 	{ "maxval",	255,	BOND_VALFLAG_MAX},
 	{ "default",	2,	BOND_VALFLAG_DEFAULT},
 	{ NULL,		-1,	0},
-- 
2.43.7