netdev - Re: [PATCH net-next] net: mana: Reduce waiting time if HWC not responding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912122849.GA30363@horms.kernel.org>
Date: Fri, 12 Sep 2025 13:28:49 +0100
From: Simon Horman <horms@...nel.org>
To: Haiyang Zhang <haiyangz@...ux.microsoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	haiyangz@...rosoft.com, decui@...rosoft.com, kys@...rosoft.com,
	wei.liu@...nel.org, edumazet@...gle.com, davem@...emloft.net,
	kuba@...nel.org, pabeni@...hat.com, longli@...rosoft.com,
	ssengar@...ux.microsoft.com, ernis@...ux.microsoft.com,
	dipayanroy@...ux.microsoft.com, kotaranov@...rosoft.com,
	shirazsaleem@...rosoft.com, andrew+netdev@...n.ch,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: mana: Reduce waiting time if HWC not
 responding

On Wed, Sep 10, 2025 at 01:57:21PM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@...rosoft.com>
> 
> If HW Channel (HWC) is not responding, reduce the waiting time, so further
> steps will fail quickly.
> This will prevent getting stuck for a long time (30 minutes or more), for
> example, during unloading while HWC is not responding.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  drivers/net/ethernet/microsoft/mana/hw_channel.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> index ef072e24c46d..ada6c78a2bef 100644
> --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> @@ -881,7 +881,12 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
>  	if (!wait_for_completion_timeout(&ctx->comp_event,
>  					 (msecs_to_jiffies(hwc->hwc_timeout)))) {
>  		if (hwc->hwc_timeout != 0)
> -			dev_err(hwc->dev, "HWC: Request timed out!\n");
> +			dev_err(hwc->dev, "HWC: Request timed out: %u ms\n",
> +				hwc->hwc_timeout);
> +
> +		/* Reduce further waiting if HWC no response */
> +		if (hwc->hwc_timeout > 1)
> +			hwc->hwc_timeout = 1;

Hi,

Perhaps it is already the case, but I'm wondering if the configured
value of hwc_timeout should be restored at some point.

>  
>  		err = -ETIMEDOUT;
>  		goto out;
> -- 
> 2.34.1
> 
>