netdev - Re: [Intel-wired-lan] [PATCH iwl-next 1/9] ice: enforce RTNL assumption of queue NAPI manipulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0438e3b9-4ada-4dc7-9ecb-e5e6a69db027@molgen.mpg.de>
Date: Fri, 12 Sep 2025 15:37:27 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, Tony Nguyen
 <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
 Simon Horman <horms@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 1/9] ice: enforce RTNL
 assumption of queue NAPI manipulation

Dear Przemek,


Thank you for the patch.

Am 12.09.25 um 15:06 schrieb Przemek Kitszel:
> Instead of making assumptions in comments move them into code.
> Be also more precise, RTNL must be locked only when there is
> NAPI, and we have VSIs w/o NAPI that call ice_vsi_clear_napi_queues()
> during rmmod.
> 
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> CC:Larysa Zaremba <larysa.zaremba@...el.com>

That address is not in Cc.

> ---
>   drivers/net/ethernet/intel/ice/ice_lib.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul