netdev - Re: [PATCH net] net: natsemi: fix `rx_dropped` double accounting on `netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCQVKZ3LKK11.50FS0CMR7ARL@gmail.com>
Date: Fri, 12 Sep 2025 23:01:48 +0900
From: "Yeounsu Moon" <yyyynoom@...il.com>
To: "Simon Horman" <horms@...nel.org>
Cc: "Andrew Lunn" <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: natsemi: fix `rx_dropped` double accounting on
 `netif_rx()` failure

On Fri Sep 12, 2025 at 10:21 PM KST, Simon Horman wrote:
>
> Thanks for your patch,
>
Thank you very much for your review, Simon :)

> Thinking out loud: Adding use of ndev->stats to drivers that don't already
> do so is discouraged. But here, an existing use is being fixed. And I agree
> it is a fix. So this looks good to me.
>
> Reviewed-by: Simon Horman <horms@...nel.org>
I also noticed that many drivers are still using `ndev->stats`.
If I work on related changes in the future, I will make sure to use
`struct rtnl_link_stats64` instaed and post patches accordingly.