netdev - Re: [PATCH net-next 3/4] net/mlx5: Add net namespace support to devcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250912141118.GD30363@horms.kernel.org>
Date: Fri, 12 Sep 2025 15:11:18 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, Mark Bloch <mbloch@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gal Pressman <gal@...dia.com>,
	Parav Pandit <parav@...dia.com>, Shay Drory <shayd@...dia.com>
Subject: Re: [PATCH net-next 3/4] net/mlx5: Add net namespace support to
 devcom

On Thu, Sep 11, 2025 at 09:31:06AM +0300, Tariq Toukan wrote:
> From: Shay Drory <shayd@...dia.com>
> 
> Extend the devcom framework to support namespace-aware components.
> 
> The existing devcom matching logic was based solely on numeric keys,
> limiting its use to the global (init_net) scope or requiring clients
> to ignore namespaces altogether, both of which are incorrect in
> multi-namespace environments.
> 
> This patch introduces namespace support by allowing devcom clients to
> provide a namespace match attribute. The devcom pairing mechanism is
> updated to compare the namespace, enabling proper isolation and
> interaction of components across different net namespaces.
> 
> With this change, components that require namespace aware pairing,
> such as SD groups or LAG, can now work correctly in multi-namespace
> scenarios. In particular, this opens the way to support hardware LAG
> within a net namespace.
> 
> Signed-off-by: Shay Drory <shayd@...dia.com>
> Reviewed-by: Mark Bloch <mbloch@...dia.com>
> Reviewed-by: Parav Pandit <parav@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

I've reviewed this with the assumptions that; mlx5_core_net() returns the
devlink net namespace, and; that the devlink net namespace is fixed.

With those assumptions, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>