netdev - Re: [PATCH net] rxrpc: Fix unhandled errors in rxgk_verify_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250912190517.GE224143@horms.kernel.org>
Date: Fri, 12 Sep 2025 20:05:17 +0100
From: Simon Horman <horms@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, netdev@...r.kernel.org,
	Marc Dionne <marc.dionne@...istor.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix unhandled errors in
 rxgk_verify_packet_integrity()

On Thu, Sep 11, 2025 at 11:58:16PM +0100, David Howells wrote:
>     
> rxgk_verify_packet_integrity() may get more errors than just -EPROTO from
> rxgk_verify_mic_skb().  Pretty much anything other than -ENOMEM constitutes
> an unrecoverable error.  In the case of -ENOMEM, we can just drop the
> packet and wait for a retransmission.
> 
> Similar happens with rxgk_decrypt_skb() and its callers.
> 
> Fix rxgk_decrypt_skb() or rxgk_verify_mic_skb() to return a greater variety
> of abort codes and fix their callers to abort the connection on any error
> apart from -ENOMEM.
> 
> Also preclear the variables used to hold the abort code returned from
> rxgk_decrypt_skb() or rxgk_verify_mic_skb() to eliminate uninitialised
> variable warnings.
> 
> Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lists.infradead.org/pipermail/linux-afs/2025-April/009739.html
> Closes: https://lists.infradead.org/pipermail/linux-afs/2025-April/009740.html
> Signed-off-by: David Howells <dhowells@...hat.com>

Reviewed-by: Simon Horman <horms@...nel.org>