netdev - Re: [PATCH net-next] selftests: ncdevmem: remove sleep on rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izNSeLSzkTsmhcVwJ1fF25Y_LY7vo_LTWtVL+Erc8dD6SQ@mail.gmail.com>
Date: Fri, 12 Sep 2025 14:06:06 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch, shuah@...nel.org, 
	joe@...a.to, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: ncdevmem: remove sleep on rx

On Fri, Sep 12, 2025 at 10:06 AM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> RX devmem sometimes fails on NIPA:
>
> https://netdev-3.bots.linux.dev/vmksft-fbnic-qemu-dbg/results/294402/7-devmem-py/
>
> Both RSS and flow steering are properly installed, but the wait_port_listen
> fails. Try to remove sleep(1) to see if the cause of the failure is
> spending too much time during RX setup.

OK, I can see that happening indeed.

> I don't see a good reason to
> have sleep in the first place. If there needs to be a delay between
> installing the rules and receiving the traffic, let's add it to the
> callers (devmem.py) instead.
>

Yeah, I was worried there would be something asynchronous about
installing flow steering rules (such as by the time when ethtool
returns, the rule is not yet fully active), that may cause some
flaky-iness, but that's unlikely the case.

> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>


-- 
Thanks,
Mina