netdev - Re: [PATCH net 1/1] net/mlx5: Clean up only new IRQ glue on request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81c62cf9-8583-46ec-b6d7-48a8c9c92fcb@oracle.com>
Date: Fri, 12 Sep 2025 09:26:28 +0530
From: Pradyumn Rahar <pradyumn.rahar@...cle.com>
To: Jacob Keller <jacob.e.keller@...el.com>,
        Mohith Kumar Thummaluru <mohith.k.kumar.thummaluru@...cle.com>,
        "saeedm@...dia.com" <saeedm@...dia.com>,
        "leon@...nel.org"
 <leon@...nel.org>,
        "tariqt@...dia.com" <tariqt@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com"
 <pabeni@...hat.com>,
        "shayd@...dia.com" <shayd@...dia.com>,
        "elic@...dia.com" <elic@...dia.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anand Khoje <anand.a.khoje@...cle.com>,
        Manjunath Patil <manjunath.b.patil@...cle.com>,
        Rama Nichanamatlu <rama.nichanamatlu@...cle.com>,
        Rajesh Sivaramasubramaniom <rajesh.sivaramasubramaniom@...cle.com>,
        Rohit Sajan Kumar <rohit.sajan.kumar@...cle.com>,
        Moshe Shemesh <moshe@...dia.com>, Mark Bloch <mbloch@...dia.com>,
        Qing Huang <qing.huang@...cle.com>
Subject: Re: [PATCH net 1/1] net/mlx5: Clean up only new IRQ glue on
 request_irq() failure

On 02-07-2025 23:28, Jacob Keller wrote:
> On 6/26/2025 11:50 PM, Mohith Kumar Thummaluru wrote:
>> The mlx5_irq_alloc() function can inadvertently free the entire rmap
>> and end up in a crash[1] when the other threads tries to access this,
>> when request_irq() fails due to exhausted IRQ vectors. This commit
>> modifies the cleanup to remove only the specific IRQ mapping that was
>> just added.
>>
>> This prevents removal of other valid mappings and ensures precise
>> cleanup of the failed IRQ allocation's associated glue object.
>>
>> Note: This error is observed when both fwctl and rds configs are enabled.
>>
> FWIW, figured i should add it here:
>
> Reviewed-by: Jacob Keller<jacob.e.keller@...el.com>
Hi, this patch has been reviewed but hasn't been applied, could you 
please look into it?