netdev - RE: [PATCH net-next v4 02/10] net: stmmac: Add support for Allwinner A523 GMAC200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0P190MB244515E7CE0741A1E47E0543BC08A@DU0P190MB2445.EURP190.PROD.OUTLOOK.COM>
Date: Fri, 12 Sep 2025 04:09:43 +0000
From: Muhammed Subair <msubair@...mail.com>
To: "wens@...nel.org" <wens@...nel.org>, "Russell King (Oracle)"
	<linux@...linux.org.uk>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Jernej Skrabec <jernej@...nel.org>, Samuel Holland
	<samuel@...lland.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-sunxi@...ts.linux.dev"
	<linux-sunxi@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Andre Przywara <andre.przywara@....com>
Subject: RE: [PATCH net-next v4 02/10] net: stmmac: Add support for Allwinner
 A523 GMAC200

Hi

There are A527 boards with 25 Mhz clock from PH13 ( rgmii-0) and PJ10 (rgmii-1). See the attached .
I believe that a patch is required to support this. Not sure it can be a global or board specific.

Subair 

-----Original Message-----
From: Chen-Yu Tsai <wens@...nel.org> 
Sent: Thursday, 11 September 2025 10:18 PM
To: Russell King (Oracle) <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Jernej Skrabec <jernej@...nel.org>; Samuel Holland <samuel@...lland.org>; netdev@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-sunxi@...ts.linux.dev; linux-kernel@...r.kernel.org; Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH net-next v4 02/10] net: stmmac: Add support for Allwinner A523 GMAC200

On Fri, Sep 12, 2025 at 2:09 AM Russell King (Oracle) <linux@...linux.org.uk> wrote:
>
> Hi,
>
> I drafted this but never sent it and can't remember why, but it's 
> relevant for v5 that you recently posted. Same concern with v5.
>
> On Tue, Sep 09, 2025 at 02:10:51AM +0800, Chen-Yu Tsai wrote:
> > +     switch (plat->mac_interface) {
> > +     case PHY_INTERFACE_MODE_MII:
> > +             /* default */
> > +             break;
> > +     case PHY_INTERFACE_MODE_RGMII:
> > +     case PHY_INTERFACE_MODE_RGMII_ID:
> > +     case PHY_INTERFACE_MODE_RGMII_RXID:
> > +     case PHY_INTERFACE_MODE_RGMII_TXID:
> > +             reg |= SYSCON_EPIT | SYSCON_ETCS_INT_GMII;
> > +             break;
> > +     case PHY_INTERFACE_MODE_RMII:
> > +             reg |= SYSCON_RMII_EN;
> > +             break;
> > +     default:
> > +             return dev_err_probe(dev, -EINVAL, "Unsupported interface mode: %s",
> > +                                  phy_modes(plat->mac_interface));
>
> I'm guessing that there's no way that plat->phy_interface !=
> plat->mac_interface on this platform? If so, please use phy_interface 
> plat->here.

Makes sense. Looking at stmmac_platform.c, for us mac_interface only comes from phy_interface.

I'll wait a day before sending yet another version.

ChenYu


Download attachment "RGMII-0.png" of type "image/png" (299066 bytes)

Download attachment "RGMII-1.png" of type "image/png" (304345 bytes)