netdev - Re: [PATCH net-next] net: stmmac: est: Drop frames causing HLBS error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5b8b21d-f326-4fd2-8791-fa507f67f273@altera.com>
Date: Fri, 12 Sep 2025 10:30:17 +0530
From: "G Thomas, Rohan" <rohan.g.thomas@...era.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Matthew Gerlach <matthew.gerlach@...era.com>
Subject: Re: [PATCH net-next] net: stmmac: est: Drop frames causing HLBS error

Hi Russell,

Thanks for reviewing the patch.

On 9/11/2025 6:21 PM, Russell King (Oracle) wrote:
> On Thu, Sep 11, 2025 at 04:38:16PM +0800, Rohan G Thomas via B4 Relay wrote:
>> @@ -109,6 +109,11 @@ static void est_irq_status(struct stmmac_priv *priv, struct net_device *dev,
>>   
>>   		x->mtl_est_hlbs++;
>>   
>> +		for (i = 0; i < txqcnt; i++) {
>> +			if (value & BIT(i))
>> +				x->mtl_est_txq_hlbs[i]++;
>> +		}
> 
> There's no need for the parens around the for loop.

Sure, will fix this in the next version.

> 
> I'm afraid I can't provide much more of a review as I don't have the
> documentation for GMAC4 or XGMAC.

Understood, thanks for taking a look regardless.

> 
Best Regards,
Rohan