netdev - Re: [PATCH net-next 1/3] net: dst_cache: implement RCU variants for dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250911180137.28b076a4@kernel.org>
Date: Thu, 11 Sep 2025 18:01:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Marek Mietus <mmietus97@...oo.com>
Cc: netdev@...r.kernel.org, antonio@...nvpn.net,
 openvpn-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next 1/3] net: dst_cache: implement RCU variants for
 dst_cache helpers

On Tue,  9 Sep 2025 07:43:31 +0200 Marek Mietus wrote:
> +/**
> + *	dst_cache_get_ip4_rcu - perform cache lookup and fetch ipv4 source
> + *	address without taking a reference on the dst

This belongs in the body, summary can be just 

				lookup cache and ipv4 source under RCU

> + *	@dst_cache: the cache
> + *	@saddr: return value for the retrieved source address
> + *
> + *	Must be called with local BH disabled, and within an rcu read side
> + *	critical section
> + */
> +struct rtable *dst_cache_get_ip4_rcu(struct dst_cache *dst_cache, __be32 *saddr);

Return: values needs to be documented these days (kernel-doc -Wall ..).

While at it please remove the old school indent by a tab.
-- 
pw-bot: cr