netdev - Re: [PATCH v3 5/5] ice: refactor to use helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250913090710.GJ224143@horms.kernel.org>
Date: Sat, 13 Sep 2025 10:07:10 +0100
From: Simon Horman <horms@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Jesse Brandeburg <jbrandeburg@...udflare.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Hariprasad Kelam <hkelam@...vell.com>,
	Marcin Szycik <marcin.szycik@...ux.intel.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>, netdev@...r.kernel.org,
	intel-wired-lan@...ts.osuosl.org, linux-doc@...r.kernel.org,
	corbet@....net, Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH v3 5/5] ice: refactor to use helpers

On Thu, Sep 11, 2025 at 04:40:41PM -0700, Jacob Keller wrote:
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> Use the ice_netdev_to_pf() helper in more places and remove a bunch of
> boilerplate code. Not every instance could be replaced due to use of the
> netdev_priv() output or the vsi variable within a bunch of functions.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c   | 48 ++++++++------------------
>  drivers/net/ethernet/intel/ice/ice_flex_pipe.c |  8 ++---
>  drivers/net/ethernet/intel/ice/ice_lag.c       |  3 +-
>  drivers/net/ethernet/intel/ice/ice_main.c      | 10 ++----
>  drivers/net/ethernet/intel/ice/ice_ptp.c       |  6 ++--
>  drivers/net/ethernet/intel/ice/ice_sriov.c     |  3 +-
>  6 files changed, 24 insertions(+), 54 deletions(-)

Less is more :)

Reviewed-by: Simon Horman <horms@...nel.org>