netdev - Re: [PATCH net] net/mlx5: report duplex full when speed is known

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bacbeaf2-104f-4da5-a66b-b8aee2b2de12@lunn.ch>
Date: Sat, 13 Sep 2025 15:47:39 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Li Tian <litian@...hat.com>
Cc: netdev@...r.kernel.org, linux-hyperv@...r.kernel.org,
	linux-kernel@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, linux-rdma@...r.kernel.org,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH net] net/mlx5: report duplex full when speed is known

On Sat, Sep 13, 2025 at 02:28:10PM +0800, Li Tian wrote:
> Prior commit in Fixes, duplex is always reported full as long
> as the speed is known. Restore this behavior. Besides, modern
> Mellanox doesn't seem to care about half duplex. This change
> mitigates duplex unknown issue on Azure Mellanox 5.
> 
> Fixes: c268ca6087f55 ("net/mlx5: Expose port speed when possible")

I'm confused with your commit message. You say DUPLEX used to be
reported as Full if the speed is known. How does c268ca6087f55 change
this? You don't say in the commit message. Why is Half duplex
important to this fix? I don't see Half anywhere in the code.

Also, what sort of problems do you see with duplex unknown? When
somebody has a problem and is looking to find a patch which might fix
it, seeing a description of the problem fixed in the commit message is
useful.

	Andrew