netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1] iavf: fix proper type for error code in iavf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS4PPF7551E6552D817075288E897C9CAA2E515A@DS4PPF7551E6552.namprd11.prod.outlook.com>
Date: Mon, 15 Sep 2025 11:28:19 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] iavf: fix proper type for
 error code in iavf_resume()



> -----Original Message-----
> From: Paul Menzel <pmenzel@...gen.mpg.de>
> Sent: Monday, September 15, 2025 11:12 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] iavf: fix proper
> type for error code in iavf_resume()
> 
> Dear Aleksandr,
> 
> 
> Thank you for your patch.
> 
> Am 12.09.25 um 10:02 schrieb Aleksandr Loktionov:
> > The variable 'err' in iavf_resume() is used to store the return
> value
> > of different functions, which return an int. Currently, 'err' is
> > declared as u32, which is semantically incorrect and misleading.
> >
> > In the Linux kernel, u32 is typically reserved for fixed-width data
> > used in hardware interfaces or protocol structures. Using it for a
> > generic error code may confuse reviewers or developers into thinking
> > the value is hardware-related or size-constrained.
> >
> > Replace u32 with int to reflect the actual usage and improve code
> > clarity and semantic correctness.
> 
> Why not use `unsigned int`?
> 
The err variable stores values returned by int typed functions().

With the best regards
Alex

> >
> > No functional change.
> >
> > Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> > ---
> >   drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > index 69054af..c2fbe44 100644
> > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > @@ -5491,7 +5491,7 @@ static int iavf_resume(struct device *dev_d)
> >   {
> >   	struct pci_dev *pdev = to_pci_dev(dev_d);
> >   	struct iavf_adapter *adapter;
> > -	u32 err;
> > +	int err;
> >
> >   	adapter = iavf_pdev_to_adapter(pdev);
> >
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul