netdev - Re: [PATCH iwl-next 2/9] ice: move service task start out of ice_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915081930.32de8247@kernel.org>
Date: Mon, 15 Sep 2025 08:19:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: <intel-wired-lan@...ts.osuosl.org>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>, Michal Schmidt
 <mschmidt@...hat.com>, Petr Oros <poros@...hat.com>, Simon Horman
 <horms@...nel.org>, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH iwl-next 2/9] ice: move service task start out of
 ice_init_pf()

On Mon, 15 Sep 2025 13:01:47 +0200 Przemek Kitszel wrote:
> On 9/13/25 01:19, Jakub Kicinski wrote:
> > On Fri, 12 Sep 2025 15:06:20 +0200 Przemek Kitszel wrote:  
> >> +	timer_setup(&pf->serv_tmr, ice_service_timer, 0);
> >> +	pf->serv_tmr_period = HZ;
> >> +	INIT_WORK(&pf->serv_task, ice_service_task);
> >> +	clear_bit(ICE_SERVICE_SCHED, pf->state);  
> > 
> > I should just read the code, but this looks like an open-coded
> > deferred_work ?  
> 
> I wanted to put some joke about our driver, but it is not funny :F
> 
> ice-service-task is scheduled both by the timer and work_queue (ice_wq),
> there is more flags that I could count around the scheduling, and it is
> a pain to stop/reset the thing - I will definitively try to simplify
> the thing (esp. given I have a bug with driver reset on me)
> 
> but for now, the cited thing is just a little chunk that I have moved
> from one function to another (and the whole series is not about a race)

FWIW a lot of races that used to exist around work scheduling are now
trivially resolved by disabling the work. But yeah, not a blocker here
obviously..