netdev - Re: [Intel-wired-lan] [PATCH iwl-next v3] idpf: add HW timestamping statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89e50ff2-5382-4d5e-a121-167704ef5b1a@molgen.mpg.de>
Date: Mon, 15 Sep 2025 18:10:42 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Anton Nadezhdin <anton.nadezhdin@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 anthony.l.nguyen@...el.com, richardcochran@...il.com,
 Milena Olech <milena.olech@...el.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] idpf: add HW timestamping
 statistics

Dear Anton,


Thank you for the improved patch.

Am 29.08.25 um 19:57 schrieb Anton Nadezhdin:
> From: Milena Olech <milena.olech@...el.com>
> 
> Add HW timestamping statistics support - through implementing get_ts_stats.
> Timestamp statistics include correctly timestamped packets, discarded,
> skipped and flushed during PTP release.
> 
> Most of the stats are collected per vport, only requests skipped due to
> lack of free latch index are collected per Tx queue.
> 
> Statistics can be obtained using kernel ethtool since version 6.10
> with:
> ethtool -I -T <interface>
> 
> The output will include:
> Statistics:
>    tx_pkts: 15
>    tx_lost: 0
>    tx_err: 0
> 
> Signed-off-by: Milena Olech <milena.olech@...el.com>
> Co-developed-by: Anton Nadezhdin <anton.nadezhdin@...el.com>
> Signed-off-by: Anton Nadezhdin <anton.nadezhdin@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
> Changelog:
> v2: Add testing information
> v3: Add check for port status to resolve driver crash during statistic
>    read when port is down
> ---
>   drivers/net/ethernet/intel/idpf/idpf.h        | 17 ++++++
>   .../net/ethernet/intel/idpf/idpf_ethtool.c    | 56 +++++++++++++++++++
>   drivers/net/ethernet/intel/idpf/idpf_ptp.c    | 11 +++-
>   .../ethernet/intel/idpf/idpf_virtchnl_ptp.c   |  4 ++
>   4 files changed, 87 insertions(+), 1 deletion(-)

[…]

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul